Skip to content

ImagePullPolicy support for GitOps Service #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 5, 2025
Merged

ImagePullPolicy support for GitOps Service #992

merged 14 commits into from
Nov 5, 2025

Conversation

@alkakumari016
Copy link
Contributor

@alkakumari016 alkakumari016 commented Oct 24, 2025

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:
This PR adds the support of configurable ImagePullPolicy through CR and env variable

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?
GITOPS-8044

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2025

Hi @alkakumari016. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@alkakumari016
Copy link
Contributor Author

alkakumari016 commented Oct 24, 2025

/ok-to-test

@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2025

@alkakumari016: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@svghadi
Copy link
Member

svghadi commented Oct 25, 2025

/ok-to-test

svghadi
svghadi reviewed Oct 28, 2025
View reviewed changes
Copy link
Member

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alkakumari016. Left few comments but overall looks good.

test/openshift/e2e/ginkgo/sequential/1-115_validate_imagepullpolicy_console_plugin_test.go
Copy link
Member

@svghadi svghadi Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a IT for IMAGE_PULL_POLICY env var?

@alkakumari016 alkakumari016 force-pushed the imagePullPolicy_gitopsService branch from a86648f to 9b3ea41 Compare October 29, 2025 11:06
@alkakumari016
Copy link
Contributor Author

alkakumari016 commented Oct 29, 2025

/retest

svghadi
svghadi reviewed Oct 30, 2025
View reviewed changes
@svghadi
Copy link
Member

svghadi commented Nov 3, 2025

/retest

@alkakumari016 alkakumari016 force-pushed the imagePullPolicy_gitopsService branch from 2b785a1 to c3a7e6e Compare November 3, 2025 10:53
@alkakumari016
Copy link
Contributor Author

alkakumari016 commented Nov 4, 2025

/retest

@alkakumari016
added imagePullPolicy config for gitops-service
474ad39 
Signed-off-by: Alka Kumari <alkumari@redhat.com>
@alkakumari016
added ginkgo test cases for imagePullPolicy feature in Gitops Servicee
a1965ba 
Signed-off-by: Alka Kumari <alkumari@redhat.com>
@alkakumari016
updated the manifest files
1c08178 
Signed-off-by: Alka Kumari <alkumari@redhat.com>
@alkakumari016
added ginkgo test case for subscription env variable for imagePullPolicy
72d17ca 
Signed-off-by: Alka Kumari <alkumari@redhat.com>
@alkakumari016
moved imagepullpolicy test for backend deployment and plugin deployme…
fc9fbe4 
…nt to sequential folder

Signed-off-by: Alka Kumari <alkumari@redhat.com>
@alkakumari016
Enabled plugin deployment in ginkgo test cases
405d904 
Signed-off-by: Alka Kumari <alkumari@redhat.com>
@alkakumari016
corrected setting up emv var
dd39e58 
Signed-off-by: Alka Kumari <alkumari@redhat.com>
@alkakumari016
typo in ginkgo test case
a21fc84 
Signed-off-by: Alka Kumari <alkumari@redhat.com>
@alkakumari016
changed os.setenv in ginkgo tes
2b2a03f 
 cases

Signed-off-by: Alka Kumari <alkumari@redhat.com>
@alkakumari016
Reused upstream GetImagePullPolicy
2b3e5d6 
Signed-off-by: Alka Kumari <alkumari@redhat.com>
@alkakumari016
downstreamed new GetImagePullPolicy function from argocd-operator
565ff2b 
Signed-off-by: Alka Kumari <alkumari@redhat.com>
@alkakumari016
changed logic to set env variable in csv
b252330 
Signed-off-by: Alka Kumari <alkumari@redhat.com>
@alkakumari016
removed unwanted code from imagepullpolicy ginkgo test case
e2ebe25 
Signed-off-by: Alka Kumari <alkumari@redhat.com>
@alkakumari016 alkakumari016 force-pushed the imagePullPolicy_gitopsService branch from a09f458 to e2ebe25 Compare November 5, 2025 05:45
@alkakumari016
commented ginkgo test case which was not working as expected
8e249e1 
Signed-off-by: Alka Kumari <alkumari@redhat.com>
@alkakumari016
Copy link
Contributor Author

alkakumari016 commented Nov 5, 2025

/retest

svghadi
svghadi approved these changes Nov 5, 2025
View reviewed changes
Copy link
Member

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Nov 5, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 5, 2025
@alkakumari016
Copy link
Contributor Author

alkakumari016 commented Nov 5, 2025

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 993a736 into redhat-developer:master Nov 5, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svghadi svghadi svghadi approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@keithchong keithchong Awaiting requested review from keithchong

Assignees

@svghadi svghadi

Labels

approved lgtm ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alkakumari016 @svghadi @openshift-merge-robot